[llvm-dev] TSAN hack on AArch64 for Android
Dan Albert via llvm-dev
llvm-dev at lists.llvm.org
Fri Aug 28 09:37:41 PDT 2015
IMO having to disable 2/3 of the tests means the patch isn't ready yet.
On Fri, Aug 28, 2015 at 9:31 AM, Jason Kim <jasonk at codeaurora.org> wrote:
> > -----Original Message-----
> > From: Renato Golin [mailto:renato.golin at linaro.org]
> > > TESTS!
> > > Currently, about 2/3 tests for tsan fail/flake on android+aarch64.
> > > They aren't xfailed, because some of them are flaky, and thus
> > unexpectedly pass at times.
> > > So I decided to mark them as unsupported on android+aarch64, and thus
> > is "green".
> > So, if they currently pass on the production buildbots, you can't mark
> > as unstable because of your patch, as that will mean your patch is
> > them unstable, and we can't just make dozens of tests unstable for any
> > amount of features.
> [ jasonk --> ] The tests, AFAIK, currently "pass" for a somewhat squiggly
> definition of "pass".
> I get occasional fails on a local x86_64 build, w/o my patches.
> > If your patch introduces the instability, you'll have to fix them before
> [ jasonk --> ] The instabilities were there to begin with, AFAIK. Some of
> the tests are run on a "deflake" regimen where they are repeated 10x,
> looking for a specific output.
> > commit. That's why I suggested splitting it into many small chunks,
> none of
> > which will leave the tree in an unstable state, because you'll have
> time to
> > look at each instability individually, and fix them before commit. The
> > will also be happier, and every one wins.
> [ jasonk --> ] Sorry, but I don't understand what you want here. The
> tests I touched are marked unsupported (i.e. won't be run at all) ONLY for
> aarch64-linux-androideabi. Is there something else you want? It should not
> impact any other configuration of TSAN/compiler-rt as-is. I also guard TSAN
> with a CMAKE variable so that it only gets built for aarch64 iff
> > cheers,
> > -renato
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev