[LLVMdev] lld coding style

Nick Kledzik kledzik at apple.com
Wed Oct 8 16:58:12 PDT 2014

On Oct 8, 2014, at 9:34 AM, Chris Lattner <clattner at apple.com> wrote:
>> On Oct 8, 2014, at 1:55 AM, Renato Golin <renato.golin at linaro.org> wrote:
>> On 8 October 2014 05:25, Chris Lattner <clattner at apple.com> wrote:
>>>> Up until now the thread has been about “formatting”.  You suggested renaming
>>>> every variable in the project!
>>> If that's what it takes.
>> If we're still talking about applying it to the HEAD, not the whole
>> history, I think it's feasible.
> Yep, to be clear, I mean one big change to head, not trying to rewrite history.
> -Chris

In case it is not clear, the lld’s convention diverge from LLVM’s in two small ways that were designed to overcome bugs in the LLVM conventions.  When the lld project first started up, I wrote the attached conventions doc to detail the reason why lld was different.  

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141008/e223f708/attachment.html>
-------------- next part --------------

Given the above reasons for the divergence, I would consider a mass variable renaming in lld sources would make the lld source base worse.  

Yes, having uniforms coding styles is nice.  Therefore, I suggest we discuss a variable naming convention that fixes LLVM's problems and can be adopted by all projects.


More information about the llvm-dev mailing list