[LLVMdev] lld coding style
chisophugis at gmail.com
Tue Oct 7 11:56:08 PDT 2014
IMHO a much bigger problem is functions (throughout LLVM and Clang) that
are still named starting with a capital letter. With LLD, the division is
simple: "is this LLVM or LLD", and this doesn't cause much mental overhead
(at least for me). But with the function name capitalization it's often
much less obvious which one it should be (quick: does raw_ostream use
capitalized function names? how about SourceMgr? How about clang's
CodeGenFunction? or clang::Parser?).
If I had one vote for a "change all the things" type renaming, I would most
definitely put it towards fixing the function capitalization issue rather
than changing LLD's naming convention.
-- Sean Silva
On Sat, Oct 4, 2014 at 11:19 PM, Saleem Abdulrasool <compnerd at compnerd.org>
> In spite of this possibly raising a holy war, I thought I would bring up
> this question again.
> When switching between a couple of LLVM repositories, I find having to
> switch between coding styles a bit of an annoyance. It always takes me a
> while to get adjusted when switching between LLVM (or clang) and lld.
> While not an absolute show stopper, not having such friction would be nicer.
> I realize that lld has had a fair amount of development and that means
> that it has a somewhat established codebase. However, having a single
> uniform style across the projects reduces the barrier to entry, encouraging
> more developers to work on various projects across the set.
> So with that in mind, I would like to ask, would it be possible to
> consider switching to LLVM style for lld?
> Saleem Abdulrasool
> compnerd (at) compnerd (dot) org
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev