[LLVMdev] lld coding style
ruiu at google.com
Mon Oct 6 17:02:46 PDT 2014
On Mon, Oct 6, 2014 at 5:00 PM, Nick Kledzik <kledzik at apple.com> wrote:
> On Oct 6, 2014, at 3:44 PM, Rui Ueyama <ruiu at google.com> wrote:
> Looks like most people in this thread support using LLVM style in LLD. I
> also had an offline discussion and many people wanted to have one coding
> style in all LLVM projects. So I'm convinced that we should do that.
> I'm going to create a patch to rename all variables if no one objects.
> I object!
I'd like to hear the reason. :)
> On Mon, Oct 6, 2014 at 3:10 PM, Bruce Hoult <bruce at hoult.org> wrote:
>> On Tue, Oct 7, 2014 at 8:54 AM, Rui Ueyama <ruiu at google.com> wrote:
>>> would touch all the lines. Diff is not powerful enough to trace the
>>> history beyond variable renaming. svn blame would become useless.
>> "useless" is much too strong a description.
>> If svn blame points to the reformat commit, then simply re-run the blame
>> on the commit before the reformat.
>> If total reformats are frequent then this is impractical. If they happen
>> once in five years then it's not really a big deal. Wrapper scripts can
>> even be pretty easily written to do this automatically.
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev