[LLVMdev] Finding safe thread suspension points while JIT-ing (was: Add pass run listeners to the pass manager.)

Chandler Carruth chandlerc at google.com
Thu May 15 13:51:43 PDT 2014


LGTM

Tiny nit:

On Thu, May 15, 2014 at 2:43 PM, Juergen Ributzka <juergen at apple.com> wrote:

> /// \brief Calls the yield callback (if applicable).
>
> ///
> /// This transfers control back to the client, which may suspend the
> current
> /// thread. Only call this method when LLVM doesn't hold any global mutex
> or
> /// cannot block the execution in another LLVM context.
> void yieldToClient();


I would just call it "yield" as we're not passing in a particular client.
This makes me think of a designated yield to some other thread in a UMS
style system. Anyways, this is down at the dim bottoms of tiny nits and
bikesheds. =D Ship it.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140515/b9ceea2b/attachment.html>


More information about the llvm-dev mailing list