[LLVMdev] [RFC] Moving OnDiskHashTable from clang to LLVM

Rafael Avila de Espindola rafael.espindola at gmail.com
Sat Mar 22 08:40:20 PDT 2014



Sent from my iPhone

> On Mar 22, 2014, at 1:31, Justin Bogner <mail at justinbogner.com> wrote:
> 
> I would like to use the on disk hash table that's currently in clang for
> instrumentation based profiling. This is a single header file that's
> currently found in include/clang/Basic/OnDiskHashTable.h, and I
> propose to move it to include/llvm/Support/OnDiskHashTable.h.
> 
> Any strong objections to moving this?
> 
> Also, the header includes a "clang::io" namespace with some operations
> for reading and writing little endian files. Should these be directly
> renamed to "llvm::io", or would something like "llvm::endian::little" or
> "llvm::le" be more reasonable?

Llvm has lib/support/endian.h. Wouldn't the new API be redundant? If not, would it fit in that header?

> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev




More information about the llvm-dev mailing list