[LLVMdev] Another phabricator feature request...

[Manuel Klimek]

On Mon, Jun 30, 2014 at 10:48 AM, Renato Golin <renato.golin at linaro.org>
wrote:

> On 27 June 2014 21:53, Duncan P. N. Exon Smith <dexonsmith at apple.com>
> wrote:
> > Then the only way for people to "accept" something is by typing text
> > to that effect.
>
> If you don't "Accept" the patch, you can't close the issue. So, either
> we send an email when people accept the patch (with LGTM or not,
> doesn't matter), or we remove the restriction on closing pending
> reviews.
>

I'm not sure why those are related - you can simply self-accept a revision
(which probably shouldn't send an LG). This is because many people don't
use phab, and so the LG only comes via the mailing list.


>
> cheers,
> --renato
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140630/d0aacbe1/attachment.html>