[LLVMdev] Usability of phabricator review threads for non-phab-users

[Aaron Ballman]

On Fri, Jul 4, 2014 at 2:21 AM, Chandler Carruth <chandlerc at google.com> wrote:
>
> On Thu, Jul 3, 2014 at 11:00 PM, Nick Lewycky <nicholas at mxc.ca> wrote:
>>
>> I don't like the lack attached patch files on the mailing list to do a
>> normal review.
>
>
> Wait what? The emails I get from phab *have* an attached patch file. That
> was a hard requirement when we first set up Phabricator.

I have definitely run into this myself. IIRC, it seems to be when
there's an update to an existing phab review, it'll have the link to
phab, but no attached patch. This usually coincides with an
inexplicable thread split.

Some examples:

Re: [PATCH] Revert the lsda change to scan_eh_tab.  (6/29)
Re: [PATCH] PR10405 Missing actual type (aka) in error message when
using decltype as a template parameter (5/29)
Re: [PATCH] Add a matcher for SubstNonTypeTemplateParmExpr. (6/29)

~Aaron