[LLVMdev] The poor organization of TargetLowering (and related subclasses) is out of hand

Chandler Carruth chandlerc at gmail.com
Wed Jul 2 18:00:03 PDT 2014


(Sorry for CC'ing piles of people, but didn't want folks to miss this in
the mailing list churn.)

See the subject. The problem is in the target-independent code generator
and especially in the x86 backend.

I would like to fix it. This will be a mechanical change just organizing
code in a way that makes it easy and fast to find methods and related
static helpers. It will not change any actual functionality. But it will
pretty much completely break the utility of looking at only a single layer
of blame. Fortunately we have nice tools like 'git blame' that can step
incrementally back through time.

If anyone is radically opposed to me cleaning up TargetLowering.h,
TargetLoweringBase.cpp, and X86ISelLowering.{h,cpp}, shout. Otherwise, I
will clean this up with a vengence. I've CC'ed piles of folks who are
actively contributing and might be seriously impacted to make sure I don't
really make life horrible for folks.

-Chandler
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140702/0b96c94a/attachment.html>


More information about the llvm-dev mailing list