[LLVMdev] [PATCH] R600 - Fix zero extend of i1

Matt Arsenault arsenm2 at gmail.com
Wed Jan 1 18:47:41 PST 2014


On Jan 1, 2014, at 9:42 PM, Jon Pry <jonpry at gmail.com> wrote:

>> This patch looks good, but you need to add a test case.  You can add it
>> to the file test/CodeGen/R600/zero_extend.ll
> 
> Version 2 of patch attached which includes test case.
> 
> 
> -Jon

It’s a good idea to include the : after the function name in the -LABEL checks. It helps avoid  problems when comments refer to the function name, or if you have several functions that start with the same thing (i.e. test1 and test10)





More information about the llvm-dev mailing list