[LLVMdev] Please change the comment of 'insert' member function of SmallPtrSetImpl

David Blaikie dblaikie at gmail.com
Fri Dec 19 13:46:08 PST 2014


Comment updated in r224619

On Thu, Dec 18, 2014 at 7:20 AM, JinGu Kang <jingu at codeplay.com> wrote:
>
> Hi all,
>
> I have a compilation failure with 'insert' member function of
> SmallPtrSetImpl class because the return value is changed from r222334. But
> the comment of the function is same with before as follows:
>
>   /// insert - This returns true if the pointer was new to the set, false
> if it
>   /// was already in the set.
>   std::pair<iterator, bool> insert(PtrType Ptr) {
>     auto p = insert_imp(PtrTraits::getAsVoidPointer(Ptr));
>     return std::make_pair(iterator(p.first, CurArray + CurArraySize),
> p.second);
>   }
>
> If the comment is changed, please change it.
>
> Thanks,
> JinGu Kang
>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141219/3674d13f/attachment.html>


More information about the llvm-dev mailing list