[LLVMdev] r204593 breaks Asan tests on FreeBSD

[Alexey Samsonov]

On Tue, Apr 1, 2014 at 1:23 PM, Ivan A. Kosarev <ivan at ivan-labs.com> wrote:

>  Hi Alexey,
>
>
> On 03/31/2014 09:58 PM, Alexey Samsonov wrote:
>
> On FreeBSD 9.2 I add a couple custom options to CMAKE_CXX_FLAGS in order
> to let clang know which header set it should use, like that:
>
>>
>>> CC=clang CXX=clang++ cmake \
>>>   -DLLVM_TARGETS_TO_BUILD=X86 \
>>>   -DCMAKE_CXX_FLAGS="-I/usr/include/c++/4.8.1
>>> -I/usr/include/c++/4.8.1/x86_64-unknown-freebsd9.2"
>>>
>>
>>  That seems unfortunate - you add x86_64- headers to CMAKE_CXX_FLAGS,
>> while sanitizers tests are built in i386 mode.
>>
>>
>>  Not just that. There are several differences between building llvm and
>> sanitizers tests that I believe should be taken into account:
>>
>
>  Correct. Yes, LLVM (and compiler-rt) can be built with gcc and with
> MSVC. Blindly passing CMAKE_CXX_FLAGS
> to Clang when building sanitizer unit tests is... wrong. For now we get
> away with this (and I decided to commit the mentioned change),
> as sanitizer unit tests are built only on unix with GCC/Clang.
>
>  Hopefully this will soon change, and by default we will build all
> compiler-rt libraries and test suites with just-built Clang. This will
> allow us to be very specific about command-line flags. Of course
> "just-built Clang" will still need to use system headers and (for unit
> tests) even system libraries, so _some_ flags must remain configurable by
> the user. But I'd rather work on the bright future than fix the existing
> and ugly clang_compile, clang_link etc. set of rules :) Let me know if
> you're OK with this, or you are in desperate need of the short-term fix (it
> prevents you from setting up a buildbot, or smth. like that).
>
>
> (Ed Maste added to CC.)
>
> Well, since the buildbot is running v9.2:
>
> lab.llvm.org:8011/builders/sanitizer_x86_64-freeBSD9.2
>
> it does indeed prevent us from enabling the bot. (Note is that D3031 was
> supposed to be the last change to commit to enable the buildbot.)
> Otherwise, I don't see any problems with waiting for the changes--given it
> won't take unreasonably long--as soon as I can do whatever local changes I
> need to make things build correctly.
>

Just curious: is it possible to revert the change locally on the buildbot
and keep it running? Or, alternatively, we can temporarily disable ASan
unit tests for FreeBSD 9.2, but still build sanitizer runtimes and run lit
tests (which would give us a pretty good coverage).


>
> Thanks.
>
> --
>
>

-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140401/b83ee8b0/attachment.html>