[LLVMdev] ErrorOr<> conflicts with unique_ptr<>

[Nick Kledzik]

Michael,

In lld, we have places that used nested a ErrorOr<std::unique_ptr<xx>> and I often hit compiler errors that require breaking up expressions to work around.   Do you have suggestions on how to code the following simple examples to not error?  Can some of these be fixed in ErrorOr.h?  Or am I totally not getting something?

-Nick


struct Foo { void doit(); };


std::unique_ptr<Foo> factoryU() {
  std::unique_ptr<Foo> f(new Foo);
  return f;  // works as expected
}

ErrorOr<Foo*> factoryE() {
  ErrorOr<Foo*> f = new Foo;
  return f;  // works as expected
}

ErrorOr<std::unique_ptr<Foo>> factoryEU() {
  std::unique_ptr<Foo> f(new Foo);
  return f; // ERROR: call to implicitly-deleted copy constructor of 'std::__1::unique_ptr<Foo, std::__1::default_delete<Foo> >’
}


void sinkU(std::unique_ptr<Foo> f) {
  f->doit();  // works as expected
}

void sinkE(ErrorOr<Foo*> f) {
  f->doit(); // ERROR: member reference base type 'typename remove_reference<Foo *>::type' (aka 'Foo *') is not a structure or union'
}

void sinkEU(ErrorOr<std::unique_ptr<Foo>> f) {
  f->doit(); // ERROR: no member named 'doit' in 'std::__1::unique_ptr<Foo, std::__1::default_delete<Foo> >'
}


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20131121/19949222/attachment.html>