[LLVMdev] Buildbot skipping commits?

[NAKAMURA Takumi]

It's a bug in buildbot. Longer (than 1024, I guess) commit message
might let buildbot commits ignored.
When buildbot is configured with mysql, such a check is done.

FYI, my buildbot tweaks longer commit log, for example;
http://bb.pgr.jp/changes/24995
(Snipping is done not in the buildmaster, but on the commit feeder)

That said, I wish every guys would not be made afraid of commit message...

Galina, FYI, it's the place to check length; master/buildbot/db/base.py

CREATE TABLE `changes` (
  (snip)
  `comments` varchar(1024) NOT NULL,
  (snip)
) ENGINE=MyISAM AUTO_INCREMENT=25011 DEFAULT CHARSET=utf8;

...I don't know why this is created as myisam and the column
"comments" would be not "text" but varchar...

2013/11/15 Daniel Sanders <Daniel.Sanders at imgtec.com>:
> Hi,
>
>
>
> Neither of my commits so far today have shown up in the buildbot console
> view. They aren't showing up in the list of changes reported by the
> changesource either.
>
> For example: http://lab.llvm.org:8011/changes/45724 shows r194805, then
> http://lab.llvm.org:8011/changes/45725 shows r194807. My commit is the
> r194806 that should be between them.
>
> Similarly change 45728 is r194810, and change 45729 is r194812. There should
> be a commit of mine (r194811) between these.
>
>
>
> Does anyone have any idea what's going on here?
>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>