[LLVMdev] About commit TILE-Gx backend to community repository and default disabled
tobias at grosser.es
Sat Mar 23 08:59:49 PDT 2013
> > Hi Jiong,
>> did you receive a full review by an LLVM committer who approved the
>> full patch set (not just individual ones) with some kind of "Looks
>> good to me"? This is the requirement Chris put for inclusion and only
>> after this has happened (and there are no major concerns found during
>> review) you should commit the back end.
>> I am myself very supportive on getting this in, but I have the feeling
>> this did not yet happen. So I propose to not commit this backend
>> prematurely. (In case I missed something and this review already
>> happened, would you mind pointing me to the email and committer who
>> reviewed the backend)
> Hi Tobias,
> thanks for your reply, it's happy to receive more feedbacks.
> below are preivous community feedbacks,
> my first post to llvm-commit mailing list:
> my second post to llvm-commit mailing list which split the big patch
> into 17 small parts:
> Anton Korobeynikov, Jakob Stoklund Olesen, Joerg Sonnenberger given some
> feedback on coding style etc, all fixed.
> do you think it's OK ? please feel free to point out if there is
> anything missing.
Yes, I have seen this and it is a very good start. Some of our core
contributors are giving you feedback to this back-end and you are
addressing their remarks. This is great.
With Chris's reply you also got the general OK to upstream the patch,
_AFTER_ the actual patches have been reviewed.
I am unsure to which extend Anton, Jakob and Joerg have reviewed your
back-end, but from the emails I have seen, I am not convinced they are
finished. I personally believe for a patch set of this size, you should
wait for an explicit email of one of the core contributors which states
that the _full_ patch set has been reviewed and is good to commit or
that an individual patch can be committed by itself.
All the best,
More information about the llvm-dev