[LLVMdev] [Patch] WinCOFFObjectWriter: fix for storing pointer to string table in header name field

Nico Rieck nico.rieck at gmail.com
Tue Jul 23 09:42:35 PDT 2013


On 23.07.2013 18:29, PaweĊ‚ Bylica wrote:
> Hi,
>
> Recently I was hit by an assert in WinCOFFObjectWriter that had forbidden
> storing pointer to string table in header name field when the pointer had
> more that 6 decimal digits. This limit had been chosen to make
> implementation easier (sprintf adds null character at the end) and could be
> increased to 7 digits.

I've already implemented this (and also included the undocumented base64 
encoding), see: http://llvm-reviews.chandlerc.com/D667

Maybe someone actually hitting this limit in practice will make someone 
accept at least the first part of D667.

-Nico




More information about the llvm-dev mailing list