[LLVMdev] [RFC] Switching make check to use 'set -o pipefail'

David Blaikie dblaikie at gmail.com
Fri Jul 19 10:03:17 PDT 2013

On Fri, Jul 19, 2013 at 6:34 AM, Reid Kleckner <rnk at google.com> wrote:
> On Wed, Jul 17, 2013 at 9:48 PM, Rafael EspĂ­ndola
> <rafael.espindola at gmail.com> wrote:
>> > Hi Rafael,
>> >
>> > Did this discussion ever get a conclusion?  I support enabling
>> > pipefail.  Fallout for out of tree users should be easy to fix.  As we
>> > learned from LLVM tests, almost all tests that start to fail actually
>> > indicate a real problem that was hidden.
>> So far I got some positive feedback, but no strong LGTM from someone
>> in the area :-(
> +1 more for pipefail, if that helps.  :)

Another +1.

> The only standing objection has to do with out-of-tree target maintainers,
> and honestly I think they'll be fine.

I'm sure they will be. This is not the worst thing they have to live
with (the API churn is massive) & that's a tradeoff we/they
deliberately make for this project: trunk moves forward.

More information about the llvm-dev mailing list