[LLVMdev] [llvm-commits] [llvm] r162770 - in /llvm/trunk: include/llvm/CodeGen/MachineOperand.h lib/CodeGen/MachineInstr.cpp

[Jakob Stoklund Olesen]

On Oct 29, 2012, at 3:28 PM, "Sergei Larin" <slarin at codeaurora.org> wrote:

> Arnold,
> 
> I wanted to hear from Jacob is the original patch in question still needed,
> since our use of this field could surpass const extenders and could
> potentially include MO_Register.
> 
> Jacob,
> 
>  Can you please comment? Thanks.

I don't really have anything to add to the commit message. There aren't plans to allow target flags on register operands.

Any particular reason you can't use immediates?

/jakob

>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=162770&view=rev
>>>> Log:
>>>> Don't allow TargetFlags on MO_Register MachineOperands.
>>>> 
>>>> Register operands are manipulated by a lot of target-independent
>>>> code, and it is not always possible to preserve target flags. That
>>>> means it is not safe to use target flags on register operands.
>>>> 
>>>> None of the targets in the tree are using register operand target
>>>> flags.
>>>> External targets should be using immediate operands to annotate
>>>> instructions with operand modifiers.