[LLVMdev] [cfe-dev] Announcement: Phabricator for code reviews
klimek at google.com
Fri Oct 19 13:17:44 PDT 2012
On Fri, Oct 19, 2012 at 1:05 AM, Michael Spencer <bigcheesegs at gmail.com>wrote:
> On Wed, Oct 17, 2012 at 10:18 AM, Manuel Klimek <klimek at google.com> wrote:
> > Dear LLVM / Clang community,
> > we'd like to open the use of Phabricator as an optional tool for doing
> > reviews to a wider audience. Please feel free to start your code reviews
> > following the documentation at http://llvm.org/docs/Phabricator.html.
> > Note that e-mail is still the reference medium for code reviews. Please
> > me know about any problems with Phabricator or the documentation you
> > Cheers,
> > /Manuel
> > _______________________________________________
> > cfe-dev mailing list
> > cfe-dev at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
> One minor issue with the patch I just sent out. If you specify a
> specific reviewer, it starts the email with Hi, <name>. Which is
> weird. In general review requests are to everyone, with specific
> people that you know care about the code in question CCed.
I added this, as it felt a little more personal to me (yea, I know, I'm
I can cut it out again if people don't like it...
Anybody else having an opinion?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-dev