[LLVMdev] [cfe-dev] Announcement: Phabricator for code reviews

[Sean Silva]

> I'd say the biggest impact of a tool like Phabricator is for larger
> pre-commit code reviews (for example by answering the question "what has
> changed since the last patch").

I was thinking of the other features as more of a "gateway drug" for
the improved code-review ;-)

-- Sean Silva

On Wed, Oct 17, 2012 at 3:00 PM, Manuel Klimek <klimek at google.com> wrote:
> On Wed, Oct 17, 2012 at 8:25 PM, Sean Silva <silvas at purdue.edu> wrote:
>>
>> You might want to mention other functionality, like Herald, which I
>> think fills a need that a lot of developers have.
>>
>> Well, I guess since this message is on the list, I can just say:
>> Phabricator's "Herald" tool lets you (among other things) set up
>> actions to happen in response to certain events; one huge use case for
>> this is setting up alerts when parts of the tree that you are
>> interested in watching get changed: this alleviates the problem of
>> missing the chance to post-commit review on changes due to messages
>> getting lost in the flood of llvm-commits mails.
>>
>> There's a lot of other functionality in Phabricator that I think might
>> be useful; the big question is how to have it integrate properly into
>> the mailing list---that's the reason I have held back in exploring
>> some of the features.
>
>
> I'd say the biggest impact of a tool like Phabricator is for larger
> pre-commit code reviews (for example by answering the question "what has
> changed since the last patch"). Thus, that's the workflow we spent some time
> tuning. If we see that more people use and like Phabricator, we'll put more
> effort into making sure other features are integrated nicely with llvm's
> existing workflows.
>
> Cheers,
> /Manuel
>
>>
>>
>> -- Sean Silva
>>
>> On Wed, Oct 17, 2012 at 1:18 PM, Manuel Klimek <klimek at google.com> wrote:
>> > Dear LLVM / Clang community,
>> >
>> > we'd like to open the use of Phabricator as an optional tool for doing
>> > code
>> > reviews to a wider audience. Please feel free to start your code reviews
>> > by
>> > following the documentation at http://llvm.org/docs/Phabricator.html.
>> >
>> > Note that e-mail is still the reference medium for code reviews. Please
>> > let
>> > me know about any problems with Phabricator or the documentation you
>> > find.
>> >
>> > Cheers,
>> > /Manuel
>> >
>> > _______________________________________________
>> > cfe-dev mailing list
>> > cfe-dev at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>> >
>
>