[LLVMdev] [PATCH][RFC] Add llvm.codegen Intrinsic To Support Embedded LLVM IR Code Generation

Tobias Grosser tobias at grosser.es
Tue May 8 02:08:46 PDT 2012


On 05/08/2012 05:13 AM, Evan Cheng wrote:
> Sorry Tobias, I'm not in favor of this change. From what I can tell, this enables some features which can implemented via other means. It adds all kinds of complexity to LLVM and I'm also highly concerned about bitcode that can embed illegal (or worse malicious) code using this feature.

Hi Evan,

there is no need to force this change in. I am rather trying to 
understand the shortcomings of my approach and look for possible better 
solutions.

That's why I was asking you where you see the possibility of 
illegal/malicious code? You did not really explain it yet and I would
be more than happy to be understand such a problem. From my point of 
view embedded and host module code are both compiled at the same time 
and are both checked by the LLVM bitcode verifier. How could this 
introduce any malicious code, that could not be introduced by normal 
LLVM-IR?

In terms of the complexity. The only alternative proposal I have heard 
of was making LLVM-IR multi module aware or adding multi-module support 
to all LLVM-IR tools. Both of these changes are way more complex than 
the codegen intrinsic. Actually, they are soo complex that I doubt that 
they can be implemented any time soon. What is the simpler approach you 
are talking about?

Maybe I completely missed the point, but if there would be a good 
alternative there would be no need to discuss. I would happily go ahead 
and implement the said alternative. Even if there is non I would keep 
quiet, after I understand the concerns that block this proposal. For 
now, I don't think I understood the concerns yet.

Cheers
Tobi




More information about the llvm-dev mailing list