[LLVMdev] [PATCH] add reverse colors to raw_ostream

[Seth Cantrell]

I'm working on a patch for clang where diagnostics print out unprintable characters vi style. I'm looking for someone familiar with llvm's raw_ostream to review the portion that enables reversed colors.

Thanks,
Seth

Begin forwarded message:

> From: Eli Friedman <eli.friedman at gmail.com>
> Subject: Re: [cfe-commits] r148389 - in /cfe/trunk: include/clang/Basic/DiagnosticLexKinds.td lib/Lex/LiteralSupport.cpp
> Date: March 23, 2012 4:49:49 AM EDT
> To: Seth Cantrell <seth.cantrell at gmail.com>
> Cc: cfe-commits at cs.uiuc.edu
> 
> On Thu, Mar 22, 2012 at 11:57 PM, Seth Cantrell <seth.cantrell at gmail.com> wrote:
>> Here are some patches for review. One enables setting reverse colors with raw_ostreams in LLVM. The other is to print unprintable characters in clang diagnostics in hex with reversed colors.
> 
> The patch for color reversal seems fine, although maybe someone more
> familiar with that code should take a look.  The patch for unprintable
> characters is a step in the right direction, but completely ignores
> the caret/ranges and fixits (so things won't line up).
> 
> I was actually hacking on this code from that angle recently; I'll
> send you what I have soon.
> 
> -Eli
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-reverseColor-to-raw_ostream.patch
Type: application/octet-stream
Size: 5032 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20120324/73115789/attachment.obj>