[LLVMdev] llvm 3.2 regression

Alexander Potapenko glider at google.com
Fri Dec 21 05:58:59 PST 2012


Neither we have them now.
Unfortunately disabling the test in the 3.2 branch won't fix the
problem, and the actual fix may require cherry-picking a number of
recent CLs, which may be rather intrusive.

On Fri, Dec 21, 2012 at 12:06 PM, Alexey Samsonov <samsonov at google.com> wrote:
> +glider
>
> Weird, we haven't seen problems with this test for quite a while.
>
>
> On Fri, Dec 21, 2012 at 12:08 AM, Jack Howarth <howarth at bromo.med.uc.edu>
> wrote:
>>
>> On Thu, Dec 20, 2012 at 11:35:47PM +0400, Anton Korobeynikov wrote:
>> > > Can this be fixed before the 3.2 release?
>> > Given that release is tomorrow, then - no, unfortunately.
>>
>> Well if you can't fix the bug by tomorrow, can't you at least revert the
>> failing part of...
>>
>>
>> https://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/tests/asan_test.cc?sortby=log&r1=145953&r2=145952&pathrev=145953
>>
>> with...
>>
>> Index: lib/asan/tests/asan_test.cc
>> ===================================================================
>> --- lib/asan/tests/asan_test.cc (revision 170724)
>> +++ lib/asan/tests/asan_test.cc (working copy)
>> @@ -2046,7 +2046,7 @@ TEST(AddressSanitizerMac, GCDSourceEvent
>>    EXPECT_DEATH(TestGCDSourceEvent(), "Shadow byte and word");
>>  }
>>
>> -TEST(AddressSanitizerMac, GCDSourceCancel) {
>> +TEST(AddressSanitizerMac, DISABLED_GCDSourceCancel) {
>>    // Make sure the whole ASan report is printed, i.e. that we don't die
>>    // on a CHECK.
>>    EXPECT_DEATH(TestGCDSourceCancel(), "Shadow byte and word");
>>
>> so that we show clean testsuite results on darwin (which is a primary
>> target)?
>>             Jack
>> ps I'll try to find sometime to regression hunt to see if this commit ever
>> passed on darwin or if it was broken on the initial backport from llvm
>> trunk.
>>
>> >
>> > --
>> > With best regards, Anton Korobeynikov
>> > Faculty of Mathematics and Mechanics, Saint Petersburg State University
>> _______________________________________________
>> LLVM Developers mailing list
>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>
>
>
> --
> Alexey Samsonov, MSK
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow



More information about the llvm-dev mailing list