[LLVMdev] [MC] [llvm-mc] Getting target specific information to <target>ELFObjectWriter

Carter, Jack jcarter at mips.com
Fri Dec 14 13:03:32 PST 2012


This is the kind of feedback I want. I believe I have to add to the base class so it should be generally useful. I can see string being better for the value. I still am enamoured with an enumeration for the tab though: int->string. How would that be a limitation?

How about the rest of the patch? 

I appreciate the feedback,

From: Eli Bendersky [eliben at google.com]
Sent: Friday, December 14, 2012 11:35 AM
To: Carter, Jack
Cc: Jim Grosbach; List
Subject: Re: [LLVMdev] [MC] [llvm-mc] Getting target specific information to <target>ELFObjectWriter

On Tue, Dec 11, 2012 at 2:48 PM, Carter, Jack <jcarter at mips.com> wrote:
> Attached are the promised patches for the below proposed change.

Just a quick question from an initial review: isn't the int->bool
mapping of flags a bit limiting. Flag can have actual values and not
only be there or not be there. Wouldn't a more generic mapping
(string->string ?) be more universally useful? Or am I missing
something obvious here...


More information about the llvm-dev mailing list