[LLVMdev] Difficulties Getting a Bug Fix Committed

Sean Silva silvas at purdue.edu
Tue Dec 4 10:07:21 PST 2012

> Can anyone help me move this forward?

My diagnosis as to what stalled the review progress was that your
original review thread seems to have gotten mangled crossing over from
llvmdev to llvm-commits (little things like that can make a

I would recommend starting a fresh new thread on llvm-commits
containing a description of the patch, why it is needed, and what
kinds of testing is added (and of course, attach the patch and make
sure it applies cleanly on trunk).

The detail of the description of what the patch does and why it is
needed should be inversely proportional to the familiarity that you
expect a reviewer to have with your code (better-justified patches
require less-expert (hence more numerous & available) reviewers). Your
original mail on Aug 21 (2nd paragraph) seems to have some good
content to incorporate into the new thread.

You may also consider CC'ing any relevant developers (from git blame
or elsewhere); ideally, for a bug fix like this, you should CC the
developer that introduced the buggy code (this may require a bit of

-- Sean Silva

On Tue, Dec 4, 2012 at 10:37 AM, Michael Muller <mmuller at enduden.com> wrote:
> Hi all,
> I've been waiting for almost three months now to get a patch committed to LLVM
> that fixes what I consider to be a fairly significant bug in the JIT
> (http://llvm.org/bugs/show_bug.cgi?id=13678) but I've been having a hard time
> getting traction on it.  So far Duncan Sands is the only one who has given it
> any attention, but as of the last time I checked it still wasn't committed and
> the bug is still open.
> Right now we ship our code with a patch to fix this in 3.1, I really don't
> want to have to do that again for 3.2.
> I appreciate the difficulties in running a project as large as LLVM, and it
> looks like there are some recent structural changes that might decentralize
> some of the review/commit burden, but it doesn't speak well for your project
> when you have a bug with a fix and a unit test just ready to go that's not
> getting into the next release.
> Can anyone help me move this forward?
> =============================================================================
> michaelMuller = mmuller at enduden.com | http://www.mindhog.net/~mmuller
> -----------------------------------------------------------------------------
> If you are not willing to control your own mind, there are plenty of other
> people who are willing to do it for you.
> =============================================================================
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev

More information about the llvm-dev mailing list