[LLVMdev] [cfe-dev] Unicode path handling on Windows
aaron at aaronballman.com
Wed Oct 12 09:42:07 PDT 2011
Yeah, I don't have commit access -- and I've found that getting Win32
patches into llvm can be like pulling teeth sometimes (I have a few
patches that are over 45 days old, and reviewed). :-(
But hopefully that process will improve as we get more Win32
developers involved in the project.
On Wed, Oct 12, 2011 at 11:34 AM, Nikola Smiljanic <popizdeh at gmail.com> wrote:
> What is the procedure now? Do we just wait for someone else to look at it
> and commit (I'm guessing that you don't have commit access)? cfe-commits is
> in the CC.
> On Tue, Oct 11, 2011 at 6:55 PM, Aaron Ballman <aaron at aaronballman.com>
>> Looks good to me!
>> On Tue, Oct 11, 2011 at 2:26 AM, Nikola Smiljanic <popizdeh at gmail.com>
>> > Fixed formatting.
>> > On Mon, Oct 10, 2011 at 9:13 PM, Aaron Ballman <aaron at aaronballman.com>
>> > wrote:
>> >> I would still fix the code formatting even though you merely
>> >> uncommented it (just to be consistent with the rest of the code). But
>> >> functionally-speaking, I think your patches are good.
>> >> ~Aaron
More information about the llvm-dev