[LLVMdev] [Patch] Let MC/ELF generate Thumb/Thumb-2 are properly

[Rafael Avila de Espindola]

> Thanks for the review and checkin.

Thanks for the patch!

> Regarding elf-thumbfunc-reloc.ll, it seems to me that current ARMAsmParser
> doesn't recognize "(PLT)", so something like  "bl foo(PLT)" doesn't work
> consequently. And I don't know how to write .s to test this without (PLT).

NP. Can you just add that as a FIXME in elf-thumbfunc-reloc.ll? That way 
we know why it is there and can port it once more of the asm parser works.

> Regarding elf-xscale-attribute.ll, those attributes are for
> ".eabi_attribute" lines
> in .s files and attributes in .aeabi section in .o files. Both .ll->.s
> and .ll->.o
> should be tested. Surely, not .s ->  .o.  I didn't write .ll ->  .s because
> ARMAsmParser ignore ".eabi_attribute" for now

Since this is something that happens in Codegen (.ll -> .s), I think 
this should probably be tested by looking at the .s produced. The fact 
that llvm-mc is still not able to process .eabi_attribute is a different 
issues which should get its own tests once it is able to.

Thanks,
Rafael