[LLVMdev] llvm-diff

John McCall rjmccall at apple.com
Tue Mar 8 09:39:43 PST 2011


On Mar 8, 2011, at 8:15 AM, Renato Golin wrote:
> I believe my refactoring went well. I've changed the source
> considerably to spread out the classes a bit so I can re-use the log
> builder and consumer. I'll also put the priority queue and the graph I
> just did on separate headers (as they are templates).

Excellent.

> I ran all tests and they pass, but I'm not sure how much llvm-diff
> relies on the check-all tests and how much you have your own tests...
> Is there anything else I can test on before sending the patches?

I'm sad to say that there isn't any formalized testing yet at all;  I just use
it and see whether it still works.

> I haven't implemented the metadata diff yet, but would be good to send
> the refactoring first, and then the graph and metadata diff. Would
> also be good to wait until next week to do so, as 2,9 is forking this
> week.

2.9 has forked, feel free to send it.

John.



More information about the llvm-dev mailing list