[LLVMdev] Lack of use of LLVMContextImpl::NamedStructTypes

[Garrison Venn]

Thanks for the clarification Eli.

In looking at a stack trace from:

Linker::LinkInFiles(…) to:
BitcodeReader::ParseTypeTableBody()

it seemed that not using NamedStructTypes would cause an issue.

Thanks again

Garrison

On Jul 25, 2011, at 14:20, Eli Friedman wrote:

> On Mon, Jul 25, 2011 at 10:50 AM, Garrison Venn <gvenn.cfe.dev at gmail.com> wrote:
>> Several people on this list have reported issues with the linker regarding a
>> named StructType instance with the same name in two different modules
>> being resolved into two StructTypes with different names due to StructType::
>> setName(…) collision behavior. Looking at BitcodeReader::ParseTypeTableBody(…),
>> I don't see use of LLVMContextImpl::NamedStructTypes or of Module::getTypeByName(…).
>> Nor do I see this use anywhere else in BitcodeReader's implementation (.cpp file).
> 
> The BitcodeReader has nothing to do with the issue in question; the
> relevant code is in lib/Linker.
> 
> -Eli