[LLVMdev] draft rule for naming types/functions/variables

Duncan Sands baldrick at free.fr
Tue Nov 23 01:12:26 PST 2010


Hi,

>    void VisitType(Type T);  // Bad -- T is too generic and could be
> mistaken for "temporary".
>    void VisitType(Type Ty);  // Bad -- Ty is not a well-known abbreviation.

I think there is a logical flaw in this argument: it doesn't matter if Ty is
not well-known in the wide world of programmers as long as it is well-known
inside LLVM: if "Ty" is used consistently all over the code base, then I think
that's good enough.

> Good point.  Done.  Hopefully this doesn't bring on bike shedding. ;-)

It just did :)

Ciao,

Duncan.



More information about the llvm-dev mailing list