[LLVMdev] Win32 COFF Support
bigcheesegs at gmail.com
Sun Jun 20 14:24:22 PDT 2010
On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote:
> The main reason I am not willing to put it in yet is (a) the size, and
> (b) the inconsistences with LLVM style. Please fix the following
> - Watch out for case mismatches, i.e., #include "WinCoff.h" when the
> header is actually WinCOFF.h.
> - The patch doesn't have a consistent newline convention, it is a
> mix of DOS and Unix.
> - if( -> if (
> - A  -> A
> - Braces go on the same line as if/else.
> - Please use AddFragment instead of add_fragment, etc, and we tend
> to only use a leading lower case for accessor methods (getFoo) or
> trivial inlines functions, but not for methods which do work or have
> substantial side effects.
> - Please use complete sentences in comments, i.e. capitalized and
> ending with proper punctuation.
> - Please don't use an extra newline following 'for' loops,
> conditionals, or type declarations.
> - Please see http://llvm.cs.uiuc.edu/docs/CodingStandards.html if
> you haven't already.
> - Daniel
Nathan and I decided to work on this patch on github until it's
finally ready and submit the proper patches against svn HEAD then. I
would like someone to review this specific diff purely for the LLVM
style issues that Daniel noted and let me know if there are any
outstanding issues on that end.
- Michael Spencer
More information about the llvm-dev