[LLVMdev] I would like to merge PARSEC into test-suite
daniel at zuster.org
Tue Jul 20 08:18:07 PDT 2010
On Tue, Jul 20, 2010 at 1:30 AM, Owen Anderson <resistor at mac.com> wrote:
> On Jul 20, 2010, at 1:18 AM, Patrick Simmons wrote:
>> It is open-source and redistributable, and I have added LICENSE.TXT
>> files to all the pieces I want to merge. These are blackscholes,
>> canneal, dedup, fluidanimate, freqmine, streamcluster, and swaptions. I
>> will disable the tests by default on the initial merge and test
>> thoroughly on Linux and MacOS before enabling them. May I please commit
>> my changes directly to test-suite?
Awesome! Can we see a patch?
The PARSEC webpage mentions that the benchmark suite is quite large.
Does your patch actually commit a specific version to the test-suite,
or is it setup like the externals tests where the user is expected to
download PARSEC on the side if they wish to test it?
> I'm not convinced that the PARSEC tests are appropriate for addition the LLVM testsuite, because they are multithreaded tests. The testsuite needs to be low-volatility in terms of performance variation, as well as easy to verify correctness, and easy for the compiler developers to debug miscompilations. I don't think PARSEC is a good match on these fronts.
I don't agree, more tests are always better. We can always invent
infrastructure to ignore the performance of certain tests if that
becomes an issue.
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu
More information about the llvm-dev