[LLVMdev] Win32 COFF Support - Patch 3

Michael Spencer bigcheesegs at gmail.com
Fri Jul 16 18:13:31 PDT 2010

On Fri, Jul 16, 2010 at 11:25 AM, Daniel Dunbar <daniel at zuster.org> wrote:
> Hi Michael,
> Overall patch looks good. I do have a few comments below. My main
> comment is please try to make the style match that used in the
> MCMachOStreamer more closely. I intend to refactor more functionality
> into the base MCObjectStreamer class, and having them use consistent
> idioms makes this easier; specific instances are included in the
> comments:

I implemented the changes and merged some stuff into MCObjectStreamer
along with marking all the functions that are basically the same.


- Michael Spencer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ms-coff-patch-3.2.patch
Type: application/octet-stream
Size: 21033 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100716/8998891a/attachment.obj>

More information about the llvm-dev mailing list