[LLVMdev] [PATCH] - Union types, replaceUsesOfWithOnConstant

[Chris Lattner]

On Feb 16, 2010, at 12:38 PM, Talin wrote:

> Here's the implementation of ConstantUnion::replaceUsesOfWithOnConstant(). No tests yet :(

Seems basically ok, please commit.

> 
> Two questions:
> 
> -- Any suggestions as to an existing test I could use as a model for testing this?

IS this what is causing this to be broken?

$ cat t.ll
@union1 = constant union { i32*, i8 } { i32* @G }
@G = global i32 4
$ llvm-as <t.ll | llvm-dis
; ModuleID = '<stdin>'

@union1 = constant union { i32*, i8 } undef       ; <union { i32*, i8 }*> [#uses=0]
@G = global i32 4                                 

> -- I could also use some advice on what part of the code to work on next (in terms of finishing up union support).

What is missing?

-Chris