[LLVMdev] [cfe-dev] draft rule for naming types/functions/variables

Zhanyong Wan (λx.x x) wan at google.com
Wed Dec 1 21:19:54 PST 2010


Thanks, Chris and John.  Committed in r120689.  I'll try to add the
*Kind rule in a separate patch.  Cheers,

On Wed, Dec 1, 2010 at 5:18 PM, Chris Lattner <clattner at apple.com> wrote:
>
> On Nov 30, 2010, at 11:29 PM, Zhanyong Wan (λx.x x) wrote:
>
>> Hi Chris,
>>
>> I've uploaded a new patch to http://codereview.appspot.com/3264041.
>> It's also attached to this message.
>
> This patch looks great to me, please apply, thanks!
>
>> I think I've addressed all your comments, except "when in doubt, an
>> enum should be a 'Kind'".  I don't think I fully understand that
>> point, and it strikes me as a bit ad hoc for the coding standards.  Do
>> we really want it?
>
> John's email sums it up really well, but I'm fine tackling this as a separate step.
>
> -Chris



-- 
Zhanyong




More information about the llvm-dev mailing list