rjmccall at apple.com
Tue Aug 24 02:12:45 PDT 2010
On Aug 24, 2010, at 1:57 AM, Renato Golin wrote:
> On 24 August 2010 00:19, John McCall <rjmccall at apple.com> wrote:
>> Note that llvm-diff is meant solely as a tool for debugging IR; pretty much all
>> details of the output, from formatting to actual information, is subject to change.
> This is fine, I'll not use it on any production system nor rely on its
> output for anything, it's also mainly for IR debugging.
Well, I hope it's useful; feel free to contribute changes.
> I noticed you have virtual functions but non-virtual destructor on
> Oracle and Consumer. It might not matter much at this stage, as
> they're not extended, but it's good to fix it. ;)
I'll "fix" it on the day it seems like a good idea to layer a API on top
of DifferenceEngine that takes ownership of an Oracle of unknown
type. I'm not sure why that would ever happen. :)
More information about the llvm-dev