[LLVMdev] Casting.h illness

Chris Lattner clattner at apple.com
Mon Aug 2 10:14:31 PDT 2010


On Jul 22, 2010, at 3:22 PM, Gabor Greif wrote:

>>> 
>>> There is one thing that is still irritating me:
>>> dyn_cast_or_null and cast_or_null have different interfaces. Should these be made consistent?
>> 
>> What do you mean?
> 
> Observe:
> 
> ... cast_or_null(Y *Val)
> ... dyn_cast_or_null(const Y &Val)
> 
> I propose:
> ... dyn_cast_or_null(Y *Val)
> 

Sure, works for me.  This shouldn't affect the interface they vend, right?

-Chris



More information about the llvm-dev mailing list