[LLVMdev] darwin llvm-gfortran Polyhedron 2005 results

[Dale Johannesen]

On Apr 8, 2010, at 11:12 AMPDT, Dale Johannesen wrote:
> On Apr 8, 2010, at 8:45 AMPDT, Bob Wilson wrote:
> [CCing Dale since this was his change, not mine]
>> 
>> The change in 81455 fixes a compiler crash.  It doesn't happen very often, but I can't imagine we would want to back that out.  Fixing it would be a more reasonable solution.  From a quick look at it, the problem is that gcc/config/darwin-c.c is registering va_opt for GC.  When you build for Fortran, darwin-c.o is not linked so the GC gets confused somehow.
> 
> This is the first I was aware this patch broke anything; nobody cc'd me on the bugzilla, and I don't normally pay attention to Fortran mail.
> 
> We definitely don't want to revert 81455; the bug caused a crash building something that's part of MacOS, and yes, that's more important than Fortran.   But it should be possible to get Fortran to build.  I would think the right idea is to change the build so that either darwin-c.o gets linked in (theoretically wrong but it should work), or (better) gt_gcc–r_gt_darwin_c_h is not referenced in Fortran.  It appears to be configured into gtype-fortran.h, which is generated during the build, so the thing would be to get it not to go in there....I'm not that expert with the GC mechanism, but I can play around a little....

There seems to be no precedent for a GC-using file that's both target and language dependent.  
c-config-lang.in looks OK for this case, although it wouldn't generalize.  This seems to work for me, does it look OK for other environments?

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.txt
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100408/29e6a760/attachment.txt>
-------------- next part --------------