[LLVMdev] Darwin option processing

[Chris Lattner]

On May 8, 2009, at 2:54 PM, Mike Stump wrote:

> On May 8, 2009, at 1:49 PM, Mike Stump wrote:
>> On May 8, 2009, at 1:02 PM, Chris Lattner wrote:
>>> This goes against our general direction for llvm libraries: they
>>> should generally all be built pic.
>>
>> After reviewing yet more of the Makefile,rules file, I believe
>> ENABLE_PIC is the right thing to check.

Looks good to me, thanks Mike.

-Chris

>>
>
> Index: clang/Makefile.rules
> ===================================================================
> --- clang/Makefile.rules        (revision 71270)
> +++ clang/Makefile.rules        (working copy)
> @@ -338,6 +338,11 @@
>        C.Flags   += -fPIC
>      endif
>    endif
> +else
> +  ifeq ($(OS),Darwin)
> +      CXX.Flags += -mdynamic-no-pic
> +      C.Flags   += -mdynamic-no-pic
> +  endif
>  endif
>
>  CXX.Flags     += $(CXXFLAGS) -Woverloaded-virtual
>
> is the patch I had in mind.  Any objections?
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev