[LLVMdev] PIC16TargetAsmInfo::getBSSSectionForGlobal

[Sanjiv Gupta]

> My short term goal is to make TargetAsmInfo not depend on libvmcore.   
> This means that no methods in it should take GlobalValue*'s for  
> example.  There is a suite of GV classification methods that need to  
> be moved somewhere else, probably in TargetLowering or asmprinter. One  
> method in particular (SectionForGlobal) is virtual and only re- 
> implemented for PIC16, which makes it an obvious candidate for changing.
>
> I don't really understand all the section handling logic, but I have  
> to untangle it.  It doesn't seem like it is properly factored somehow,  
> so I'd like to simplify it while I'm moving stuff. 
PIC16 has a lot of things going on in asmprinter while sectionizing globals.
Let us know if you need to understand anything.

>  I don't want to  
> break PIC16, but again, there are no testcases!
>
> -Chris
>   
We do have a lot of execution tests locally. But we haven't added any to 
the test/CodeGen because of lack of time.
I can help you testing your patch.

- Sanjiv