[LLVMdev] MCInst

[Chris Lattner]

On Jul 10, 2009, at 8:59 AM, David Greene wrote:

> On Friday 10 July 2009 00:19, Chris Lattner wrote:
>
>> asmprinter::printInstruction will lower a MachineInstr to an MCInst,
>> then call the MCInst asmprinter to do the hard formatting work.  You
>> can see a horrible simple skeleton of this idea in
>> X86ATTAsmPrinter::printMachineInstruction.
>
> Yep, that's where I hit the problem.  I'm patching the sources for the
> comment emitter and of course MCInst doesn't have the right interfaces
> yet.
>
>>> I'm porting some
>>> patches we have here that affect MachineInstrs and am wondering
>>> whether I
>>> need to make similar changes in MCInst.
>>
>> You should almost certainly do everything on MachineInstr.  MCInst is
>> still very early on, if you make any changes to MachineInstr I'll
>> update MCInst to match.  Please discuss changes to core data
>> structures like MachineInstr before you make them though.
>
> In this case LLVM won't build without MCInst updates.  Should I go  
> ahead
> and do those and submit the patch to the dev list?

Sure, sounds good.  This is even more reason to make your stream part  
of libsupport, not libcodegen :)

-Chris