[LLVMdev] [PATCH] Fix for bugpoint -remote-client

Viktor Kutuzov vkutuzov at accesssoftek.com
Wed Jul 8 13:52:20 PDT 2009


> bugpoint should be a standalone tool. It should not require a separate
> script to handle remote execution. Why is the script needed?

Bugpoint is a standalone too and does not require any separate script.
The script is a helper for using ssh as a remote client.

Bugpoint should not be aware of any details how the test program will be delivered to a remote target, get executed there, and how 
the result of execution will be returned back to the host.
So, it expects the "remote client" - whatever it is - take care of those 3 things.
The RemoteRunSafely.sh does all these by using ssh.

Viktor

----- Original Message ----- 
From: "Evan Cheng" <evan.cheng at apple.com>
To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu>
Sent: Wednesday, July 08, 2009 1:33 PM
Subject: Re: [LLVMdev] [PATCH] Fix for bugpoint -remote-client


>
> On Jul 8, 2009, at 12:42 AM, Viktor Kutuzov wrote:
>
>> Hello Evan,
>>
>> Thanks for looking at the patch.
>>
>>> This should use std::cerr and make sure it is wrapped inside the
>>> DEBUG
>>> macro.
>>
>> Will do.
>>
>>> Also, we don't want RemoteRunSafely.sh  to be under utils/bugpoint.
>>> Can you move it to test-suite? Are you planning to change the llvm
>>> test suite makefile to make use of RemoteRunSafely.sh?
>>
>>
>> I thought about bugpoint remote mode and the RemoteRunSafely.sh
>> script more as a manual tool rather than a part of the test suit.
>> Unless I'm missing something, getting it there will add some
>> dependencies which are not for a regular build system.
>> This is why I have placed the script under utils/bugpoint.
>>
>> But it sounds like you have an idea how to do this. Would you
>> explain your thoughts, please?
>
> I guess I don't understand the point of RemoteRunSafely.sh then. I
> thought it's meant to be a script that parallel RunSafely.sh for
> bugpoint'ing miscompilations of llvm test suite.
>
> bugpoint should be a standalone tool. It should not require a separate
> script to handle remote execution. Why is the script needed?
>
> Evan
>
>
>>
>> Best regards,
>> Viktor
>>
>> ----- Original Message -----
>> From: "Evan Cheng" <evan.cheng at apple.com>
>> To: "LLVM Developers Mailing List" <llvmdev at cs.uiuc.edu>
>> Sent: Tuesday, July 07, 2009 6:08 PM
>> Subject: Re: [LLVMdev] [PATCH] Fix for bugpoint -remote-client
>>
>>
>>> Thanks Viktor.
>>>
>>> +    std::cout << "<run locally>" << std::flush;
>>>
>>> This should use std::cerr and make sure it is wrapped inside the
>>> DEBUG
>>> macro.
>>>
>>> Also, we don't want RemoteRunSafely.sh  to be under utils/bugpoint.
>>> Can you move it to test-suite? Are you planning to change the llvm
>>> test suite makefile to make use of RemoteRunSafely.sh?
>>>
>>> Thanks,
>>>
>>> Evan
>>>
>>> On Jul 7, 2009, at 4:32 PM, Viktor Kutuzov wrote:
>>>
>>>> Hello everyone,
>>>>
>>>> Please find the patch attached.
>>>> This fixes the bugpoint -remote-client and adds a helper script for
>>>> a remote run.
>>>>
>>>> -Viktor
>>>> <ToolRunner.diff>_______________________________________________
>>>> LLVM Developers mailing list
>>>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>>>
>>> _______________________________________________
>>> LLVM Developers mailing list
>>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>>>
>> _______________________________________________
>> LLVM Developers mailing list
>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> 




More information about the llvm-dev mailing list