[LLVMdev] LLVM 2.4 Dominance Frontier Problem

[Devang Patel]

On Feb 18, 2009, at 9:35 AM, David Greene wrote:

>> Go and fix the last pass that mainpulated dominator info or
>> file a PR with reproducible test case for mainline. IIRC, dom info
>> verifier is not enabled by default.
>
> No, it's not and it looks like that was the problem.
>
> This looks like it's another misuse of C++.  When I turn on
> --enable-expensive-checks, things blow up all over the place.   
> There's an
> increment of a singular iterator in CominanceFrontierBase::compare.
>
> I fixed this issue and that solved the problem on my current testcase.

Great! Pl. apply the fix to mainline also.

> We really need to start testing with --enable-expensive-checks.  After
> finishing up the details of our merge, I'm going to go polish the  
> validator
> some more.

Thanks!
-
Devang