[LLVMdev] svn pre-commit hook: help needed

Devang Patel dpatel at apple.com
Wed Feb 18 08:53:00 PST 2009


On Feb 18, 2009, at 1:41 AM, Julien Lerouge wrote:

> Yet another _fun_ way of doing this is to setup a buildbot slave just
> for that. The slave can fix minor stuff like tabs and trailing
> whitespaces on its own (checking the changes back in), and yell for
> things like 80-col violations and whatnot where the changes would  
> not be
> so trivial.

If you're going to change anything then this is the best alternative,  
otherwise I can live with status quo.

Do not reject commit just because of formatting issues. It can have  
serious -ve impact on productivity.

To folks who prefers to reject commits due to formatting errors -- You  
already rely on a some kind of "tool" to make your day to day life  
easier. [ Most likely you've your editor automatically replacing tabs  
into spaces. Your terminal window is only 80 col. wide or your editor  
is displaying a vertical line to warn you about 80 col. and so  
on... ]. The  build bot suggested by Julien is yet another "tool" that  
accomplishes the same.  One the slave bot can use clang static  
analyzer ... :)

-
Devang



More information about the llvm-dev mailing list