[LLVMdev] Possible Typo in SelectionDAGLowering::visitShuffleVector

Marius Wachtler malloc at inode.at
Fri Aug 21 08:49:13 PDT 2009


Hello

While building LLVM, the compiler (static analysis) is giving me a warning
about "if (RangeUse[0] == 0 && RangeUse[0] == 0) {".
Can somebody familar with the codebase look over it, maybe this should be
"if (RangeUse[0] == 0 && RangeUse[1] == 0) {", otherwise sorry for the
noise.



Index: F:/dev/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp
===================================================================
--- F:/dev/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp    (revision
79629)
+++ F:/dev/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuild.cpp    (working
copy)
@@ -2522,7 +2522,7 @@
       }
     }

-    if (RangeUse[0] == 0 && RangeUse[0] == 0) {
+    if (RangeUse[0] == 0 && RangeUse[1] == 0) {
       setValue(&I, DAG.getUNDEF(VT));  // Vectors are not used.
       return;
     }

Marius Wachtler
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20090821/3fd69d3a/attachment.html>


More information about the llvm-dev mailing list