[LLVMdev] Implementing llvm.atomic.cmp.swap.i32 on PowerPC

Evan Cheng evan.cheng at apple.com
Fri Jul 11 10:54:20 PDT 2008


Hi Gary,

This does not patch cleanly for me (PPCISelLowering.cpp). Can you  
prepare a updated patch?

Thanks,

Evan

On Jul 10, 2008, at 11:45 AM, Gary Benson wrote:

> Cool, that worked.  New patch attached...
>
> Cheers,
> Gary
>
> Evan Cheng wrote:
>> Just cast both values to const TargetRegisterClass*.
>>
>> Evan
>>
>> On Jul 10, 2008, at 7:36 AM, Gary Benson wrote:
>>> Evan Cheng wrote:
>>>> How about?
>>>>
>>>> const TargetRegisterClass *RC = is64Bit ? &PPC:GPRCRegClass :
>>>> &PPC:G8RCRegClass;
>>>> unsigned TmpReg = RegInfo.createVirtualRegister(RC);
>>>
>>> I tried something like that yesterday:
>>>
>>> const TargetRegisterClass *RC =
>>>   is64bit ? &PPC::GPRCRegClass : &PPC::G8RCRegClass;
>>>
>>> but I kept getting this error no matter how I arranged it:
>>>
>>> error: conditional expression between distinct pointer types
>>> ‘llvm::PPC::GPRCClass*’ and ‘llvm::PPC::G8RCClass*’ lacks a cast
>>>
>>> Any suggestions?
>>>
>>> Cheers,
>>> Gary
>>>
>>> -- 
>>> http://gbenson.net/
>>> _______________________________________________
>>> LLVM Developers mailing list
>>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>>
>>
>> _______________________________________________
>> LLVM Developers mailing list
>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
> -- 
> http://gbenson.net/
> <ppc-atomics- 
> take3.patch>_______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev





More information about the llvm-dev mailing list