[LLVMdev] TargetISelLowering

[Chris Lattner]

On Dec 1, 2008, at 8:53 AM, Matthijs Kooijman wrote:

> Hi All,
>
> when looking through all the existing targets, I see that each of  
> them defines
> <Target>ISelLowering.{cpp,h} files. However, they define a class  
> called
> "<Target>TargetLowering" (though the comments in [at least some of]  
> those
> files stay the define "<Target>ISelLowering".
>
> I suspect that this class was renamed at some time (which makes  
> sense, since I
> don't think that the TargetLowering classes have anything to do with
> instruction selection [any more?]). However, the inconsistent  
> filenames are a
> bit confusing. Perhaps somebody should rename the lot of them?

Sure, I'd support renaming them to <target>TargetLowering.cpp etc.

> The same goes for <Target>ISelDAGToDAG.cpp, which defines a class  
> called
> <Target>DAGToDAGISel.

The DAGToDAG suffix is actually a pretty old historical artifact at  
this point.  It would be better to rename the classes and files to  
<target>DAGISel.

-Chris