[LLVMdev] ComputeMaskedBits Bug
evan.cheng at apple.com
Wed Aug 20 16:08:19 PDT 2008
Sorry for being out of touch. Has this been fixed?
On Jul 21, 2008, at 1:09 PM, David Greene wrote:
> On Saturday 19 July 2008 23:53, Nick Lewycky wrote:
>>> That said, there are many places that don't respect the Mask.
>>> reading of the comment leads me to believe the Mask is simply a
>>> time-saving device, not a correctness-enforcing mechanism.
>> That's fine, but if you fix it that way, please audit
>> InstructionCombiner SimplifyDemandedBits, which I believe has the
>> same bug.
>>> I've fixed the PHI analysis to do the min in our code and it fixes
>>> testcase I was working on. Doing a min like this would also allow
>>> to have PHI nodes compute known zero and one bits even when there
>>> isn't a recurrence.
>> Great! Did you commit a patch for this?
> Not yet. :( I am waiting for some paperwork on this end.
> Hopefully we only
> have to go through this pain once and then I can be much more
> active. I've
> been told it should be approved by the end of the month.
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu
More information about the llvm-dev