[LLVMdev] Cleanup of constant sequence type construction

Devang Patel dpatel at apple.com
Wed Aug 13 16:26:50 PDT 2008

On Aug 13, 2008, at 4:08 PM, Daniel Dunbar wrote:

> The methods for constructing constant sequencish types (struct,  
> array, vector) aren't
> consistent and we are missing a few useful convenience methods. I  
> would like to change
> the interfaces to each support four construction methods:
> (a) With and without a type.

What is the use of ConstantStruct without a type ?

> (b) With a vector or an array + size.
> [snip]

> While I am at it it would make sense to make the array + size  
> methods more
> efficient (not construct a vector).

Why not ?

> Any problems?

One suggestion, while you're here, add methods that use SmallVector  
(IMO removing methods that use std::vector is a good idea).


More information about the llvm-dev mailing list