[LLVMdev] PATCH: Use size reduction -- wave2
gohman at apple.com
Tue Apr 15 17:13:46 PDT 2008
Can you provide performance data for this? I'd
like to know what affect these changes have on
On Apr 15, 2008, at 3:32 PM, Gabor Greif wrote:
> Hi All,
> here comes the patch for the second wave of Use class size reduction.
> I have included all the machinery that is needed, and it is
> *active*. The User* inside of Use is even sometimes NULL,
> but the algorithm is able to recover it.
> If there is a non-null User* present, then I am
> asserting that it equals the computed value.
> I did not receive feedback for the algorithmic part yet,
> so I assume, you are comfortable with it.
> Unfortunately I had to introduce a new GlobalVariable::Create
> mechanism (I hoped to have nailed all in wave 1, but life is cruel).
> I will submit scripts for the easy conversion of external projects
> like the last time.
> I have split this review material into 3 files, corresponding to
> - essential changes,
> - related changes in .cpp files,
> - collateral nitty-gritty, mostly mechanical stuff.
> Outlook: The actual removal of the Use::U member
> will happen in wave 3 after this stuff is merged to
> trunk. I do not expect any problems.
> Btw., I have already performed a test merge
> and it also passes all tests (deja, clang, test-suite).
> --------------------- STATS ------------------
> ggreif$ ls -l wave2*
> -rw-r--r-- 1 ggreif ggreif 79367 Apr 16 00:20 wave2-
> -rw-r--r-- 1 ggreif ggreif 51795 Apr 16 00:24 wave2-impl.diff
> -rw-r--r-- 1 ggreif ggreif 25300 Apr 16 00:25 wave2-
> ggreif$ wc wave2*
> 2189 9005 79367 wave2-essentials.diff
> 1408 4793 51795 wave2-impl.diff
> 521 1995 25300 wave2-nittygritty.diff
> 4118 15793 156462 total
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu
More information about the llvm-dev